-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito-identitypool-alpha): add addRoleMappings
method
#33820
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33820 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #33725
Reason for this change
Currently, there exists a circular dependency for IAM roles and Identity Pools, where the role mappings cannot be specified without an identity pool ID, but we cannot get the identity pool IDs without also creating the pool, which must be created with the role. By re-introducing the
addRoleMappings
method, we allow for these role mappings to be tweaked later in execution, breaking the cyclic dependency.Description of changes
Included
addRoleMappings
method, which takes a list ofIdentityPoolRoleMapping
and overrides the existing property with these additional roles. The previous role mappings are preserved, and only appended with the additional ones.Describe any new or updated permissions being added
N/A, as the only change here is customers now being able to add to their own role mappings.
Description of how you validated changes
Added new unit tests and integration tests; unit tests succeed via
yarn build
and the integration test passes viayarn integ test/integ.identitypool.js --update-on-failed
, as evident by the updated snapshot.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license