Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): connectable ec2.Prefixlist #33813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

watany-dev
Copy link
Contributor

Issue # (if applicable)

There was no special reason for this PR, it simply stopped.

#32084

Reason for this change

Prefix lists are often used in EC2 ingress and egress configurations, but the current interface is unnecessarily complex.

const sg = new SecurityGroup(stack, 'SecurityGroup', { vpc });
sg.connections.allowFrom(Peer.prefixlist(prefixList.prefixlListId), Port.tcp(443));
const sg = new SecurityGroup(stack, 'SecurityGroup', { vpc });
sg.connections.allowFrom(prefixList, Port.tcp(443));

Describe any new or updated permissions being added

None

Description of how you validated changes

integ fixed.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 18, 2025 08:14
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Mar 18, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (e6f5bc8) to head (76418b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33813   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watany-dev watany-dev changed the title feat(ec2): Connectable Prefixlist feat(ec2): connectable ec2.Prefixlist Mar 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 18, 2025 08:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 76418b8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Tietew
Copy link
Contributor

Tietew commented Mar 18, 2025

Hi @watany-dev
Good work but this PR seems to be a duplicate of my #33617
Cloud you take a look at my PR please?
Thank you.

@watany-dev
Copy link
Contributor Author

Understood. I'll move on to your review there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants