fix(events-targets): rename KinesisFirehoseStreamV2 to FirehoseDeliveryStream
#33798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
star-contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33798 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aws-cdk-automation
added
the
pr/needs-community-review
Merged
1 task
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…o `FirehosePutRecord` (#33758) ### Issue # (if applicable) Related to #33757 and #33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hwum
pushed a commit
to hwum/aws-cdk
that referenced
this pull request
Mar 18, 2025
…o `FirehosePutRecord` (aws#33758) ### Issue # (if applicable) Related to aws#33757 and aws#33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related to #33757 and #33758
Reason for this change
Current
aws_events_targets.KinesisFirehoseStreamV2target class has following issues:IDeliveryStreamwhich is a subset ofaws_kinesisfirehose.IDeliveryStreamwithout inheritance. This may cause jsii type compatibility problem.Description of changes
FirehoseDeliveryStreamtarget class derived fromKinesisFirehoseStreamV2but receivesaws_kinesisfirehose.IDeliveryStreaminstead.KinesisFirehoseStreamV2and internalIDeliveryStream.FirehoseDeliveryStreamFirehoseDeliveryStreamand assertions.Describe any new or updated permissions being added
N/A -
FirehoseDeliveryStreamadds same permissions asKinesisFirehoseStreamV2Description of how you validated changes
Unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license