fix: dependencies and typing #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-bq
reviewed
Sep 25, 2025
| import { DriverConnectionProvider } from "../../common/lib/driver_connection_provider"; | ||
| import { AwsClientConfig } from "../../common/lib/wrapper_property"; | ||
|
|
||
| export interface AwsMysQLClientConfig extends ConnectionOptions, AwsClientConfig {} |
There was a problem hiding this comment.
Suggested change
| export interface AwsMysQLClientConfig extends ConnectionOptions, AwsClientConfig {} | |
| export interface AwsMySQLClientConfig extends ConnectionOptions, AwsClientConfig {} |
| /** Set to true if you are providing a connection string with multiple comma-delimited hosts and your cluster has only one writer. The writer must be the first host in the connection string */ | ||
| singleWriterConnectionString?: boolean; | ||
| /** Enables replacing a green host name with the original hostname after a blue/green switchover and the green name no longer resolves. */ | ||
| enableGreenHostReplacement?: boolean; |
There was a problem hiding this comment.
Should this be placed near the other bgd related properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move runtime dependencies that need to be provided by users to peerDependencies.
Add custom AwsClientConfig class.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.