Fixes bug in DNS configuration for SC-enabled tasks in BR. #4787
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gate platfomrs that use netlib (internal platforms like EC2 debug and Omakase)
xxx0624
reviewed
Sep 26, 2025
|
|
||
| func (c *containerdDebug) CreateDNSConfig(taskID string, netNS *tasknetworkconfig.NetworkNamespace) error { | ||
| return c.common.createDNSConfig(taskID, true, netNS) | ||
| // SC tasks will get DNS config from control plane |
There was a problem hiding this comment.
nonblocking: can we have some context why the DNS config from customer can help for SC?
There was a problem hiding this comment.
can we have a unit test for this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in DNS configuration for SC-enabled tasks in BR.
This change fixes a bug in the DNS configuration for managed_linux instances and internal ec2 debug platforms.
In SC enabled tasks, we always have to get DNS configuration from the control plane. This change adds logic to check if new AWSVPC network namespace requires the platform to get DNS config from the task payload or if we get DNS configuration from the host files.
Summary
This change fixes a bug in the DNS configuration for managed_linux instances and internal ec2 debug platforms.
In SC enabled tasks, we always have to get DNS configuration from the control plane. configuration from the host files.
Implementation details
This change adds logic to check if new AWSVPC network namespace requires the platform to get DNS config from the task payload or if we get DNS
Testing
Internal end-to-end tests. Two services talk to each other in ec2-debug mode using Bottlerocket OS.
New tests cover the changes:
Description for the changelog
Fixes bug in DNS configuration for SC tasks in BR platforms
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.