Skip to content

feat(capacity-provider): restore Journey 1 - #2114

Open
aidandaly24 wants to merge 5 commits into
aws:mainfrom
aidandaly24:feat/restore-capacity-provider
Open

feat(capacity-provider): restore Journey 1#2114
aidandaly24 wants to merge 5 commits into
aws:mainfrom
aidandaly24:feat/restore-capacity-provider

Conversation

@aidandaly24

Copy link
Copy Markdown
Contributor

Description

Restores capacity provider Journey 1 after #2045.

This is the exact inverse of revert commit 0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9, applied to current main. It restores the capacity provider schema, CLI and TUI add/remove flows, deploy/status/output handling, telemetry, documentation, and tests from #2030.

Companion CDK PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/340

Related Issue

Restores #2030 after #2045.

Documentation PR

N/A. User-facing documentation is restored in this PR.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • npm run test:unit (431 files, 6,193 tests passed)

  • npm run test:integ (35 files, 350 tests passed, 1 skipped)

  • npm run test:update-snapshots (6,193 tests passed, no snapshot drift)

  • npm run typecheck

  • npm run lint

  • npm run format:check

  • npm run build

  • npm run test:tui reproduced the exact current-main result: 15 passed and 19 pre-existing failures, with no capacity-provider failures

  • Verified the complete branch diff is byte-for-byte equivalent to the inverse of 0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9

  • I ran npm run test:unit and npm run test:integ

  • I ran npm run typecheck

  • I ran npm run lint

  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@aidandaly24
aidandaly24 requested a review from a team August 26, 2026 18:35
@github-actions github-actions Bot added the size/xl PR size: XL label Aug 26, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.28.0.tgz

How to install

gh release download pr-2114-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.0.tgz

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

I verified this PR is exactly what it claims: a clean revert-of-revert restoring PR #2030 after the temporary revert in #2045.

Verification performed:

  • Checked out origin/main and ran git revert 0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9. Git applied it automatically with no conflicts.
  • Diffed the result against the PR head (git diff pr-2114) → empty output. The 44 files and 2,240/42 line stats match the inverse of the revert byte-for-byte.
  • Confirmed the intervening feat(payments): Quick Create connector flow changes (#2017) to src/cli/commands/status/action.ts are preserved — both getPaymentConnector/paymentConnectors and the newly re-added capacityProviders diff logic coexist in the final file.
  • The CLI side of capacity provider is loosely coupled to the L3 construct: schema JSON writes on add/remove, and parseCapacityProviderOutputs just reads CFN outputs by name pattern — so this can land independently of the companion CDK PR without runtime issues (deploy just won't populate capacity provider outputs until the L3 lands).
  • Telemetry restoration is included (command-run.ts, common-shapes.ts).

No new code changes are being introduced beyond the previously-reviewed #2030 content, so I have nothing new to flag. Safe to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant