Skip to content

fix(ci): run refactor PR automation from main - #2103

Closed
tejaskash wants to merge 2 commits into
mainfrom
fix/refactor-bun-pr-automation
Closed

fix(ci): run refactor PR automation from main#2103
tejaskash wants to merge 2 commits into
mainfrom
fix/refactor-bun-pr-automation

Conversation

@tejaskash

Copy link
Copy Markdown
Contributor

Summary

  • set the Harness reviewer model to us.anthropic.claude-opus-5
  • generate Bun tarballs for authorized PRs targeting refactor on open, reopen, and synchronize
  • support explicit tarball reruns through workflow_dispatch
  • post a sticky install comment against the resolved PR

Context

pull_request_target loads workflow definitions from the repository default branch. The Bun workflow merged to refactor in #2100 therefore cannot control refactor PR open events; the default-branch pr-automation.yml must route those events.

The existing npm E2E and tarball workflows remain scoped to main/feat/**. This job is additionally gated to base.ref == refactor, so the package-manager paths do not overlap.

Verification

@tejaskash
tejaskash requested a review from a team August 25, 2026 19:22
@github-actions github-actions Bot added the size/m PR size: M label Aug 25, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.28.0.tgz

How to install

gh release download pr-2103-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.0.tgz

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 25, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Workflow-only change; no application code, tests, or telemetry surface area to consider. I reviewed both the diff and the resulting .github/workflows/pr-automation.yml end-to-end.

Things I checked and consider fine:

  • Fork-PR safety. tarball-authorize gates on AUTHORIZED_USERS via fetch-secrets / check-authorized-user before the pr-tarball job runs bun install / bun run build / bun pm pack on PR head code. This matches the existing pr-tarball.yml precedent (same gate pattern, same allow-unsafe-pr-checkout: true justification).
  • workflow_dispatch path. Authz steps correctly skip on dispatch (if: github.event_name == 'pull_request_target'), and Determine authorization short-circuits to is_authorized=true for dispatch — dispatch already requires repo write. PR_NUMBER is regex-validated (^[0-9]+$) before being used with gh api, and the resolver rejects non-refactor bases so a mis-dispatched run fails loudly instead of packing the wrong PR.
  • Sticky-comment collision. Both this job and the existing pr-tarball.yml use header: tarball, but they fire on disjoint base refs (refactor here vs. main/feat/** there), so no PR will ever see both.
  • Release lifecycle. gh release delete "$tag" --yes --cleanup-tag before gh release create ... --draft --target "$HEAD_SHA" is idempotent across synchronize events. (Note: the existing cleanup-pr-tarballs.yml filters on .isPrerelease, which does not match --draft releases — same pre-existing quirk as pr-tarball.yml, so this PR isn't making anything worse. Worth cleaning up separately if drafts are accumulating.)
  • Comment accuracy. # pull_request_target workflows are loaded from main… matches the PR description's motivation for hoisting the refactor tarball logic here rather than leaving it on the refactor branch.

YAML parses cleanly and all five jobs (size-title, security-review, harness-review, tarball-authorize, pr-tarball) are well-formed. No changes requested.

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.99% 15453 / 37694
🔵 Statements 40.24% 16473 / 40935
🔵 Functions 35.15% 2644 / 7522
🔵 Branches 34.18% 10311 / 30161
Generated in workflow #4412 for commit 035ff95 by the Vitest Coverage Report Action

@tejaskash tejaskash closed this Aug 25, 2026
@tejaskash
tejaskash deleted the fix/refactor-bun-pr-automation branch August 25, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant