fix: validate existing IAM role trust policies - #2033
Merged
Conversation
nborges-aws
had a problem deploying
to
e2e-testing
August 18, 2026 23:26 — with
GitHub Actions
Failure
Contributor
Package TarballHow to installgh release download pr-2033-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.27.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Coverage Report
|
aidandaly24
approved these changes
Aug 19, 2026
aidandaly24
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me no findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds trust-policy validation before reusing an existing managed IAM role in the imperative
agentcore run ab-testpath--role-arnBehavior Change
Existing AB tests are unaffected. New roles, matching existing roles, and explicit customer-managed roles continue to work normally.
When creating, retrying, or recreating an AB test without
--role-arn, the CLI will now reject an existing deterministic role whose trust policy differs from the policy it would create.Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.