Skip to content

fix: remove duplicate canary failure notification - #1959

Merged
tejaskash merged 1 commit into
aws:mainfrom
Hweinstock:fix/remove-duplicate-canary-notification
Aug 10, 2026
Merged

fix: remove duplicate canary failure notification#1959
tejaskash merged 1 commit into
aws:mainfrom
Hweinstock:fix/remove-duplicate-canary-notification

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

Canary failures create both an internal ticket and a GitHub issue. These are not linked, causing confusion about where to look.

Solution

Remove the "Create canary failure issue" step and its "Generate GitHub App Token" dependency from the canary workflow. Also remove the now-unused create-failure-issue.ts script.

Testing/Verification

  • Verified no other workflows reference create-failure-issue.ts
  • Verified the app-token step was only used by the removed issue-creation step
  • The canary heartbeat/CloudWatch alarm path remains intact as the primary notification mechanism

Closes #1958

@github-actions github-actions Bot added the size/m PR size: M label Aug 10, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Aug 10, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 10, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.26.0.tgz

How to install

gh release download pr-1959-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.26.0.tgz

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 10, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 10, 2026 13:56
@Hweinstock
Hweinstock requested a review from a team August 10, 2026 13:56
@tejaskash
tejaskash merged commit c00bf7a into aws:main Aug 10, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: duplicate notification on canary failure

3 participants