Skip to content

feat: add read-only datasets TUI - #1932

Merged
nborges-aws merged 2 commits into
refactorfrom
datasets-readonly-TUI
Aug 13, 2026
Merged

feat: add read-only datasets TUI#1932
nborges-aws merged 2 commits into
refactorfrom
datasets-readonly-TUI

Conversation

@nborges-aws

@nborges-aws nborges-aws commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Adds an interactive, read-only TUI for the eval dataset command tree. Follows conventional menu → list → detail → JSON flow. Bare commands eval dataset, eval dataset list, eval dataset get now open TUI flows instead of missing flag error messaging.

Screens

Path Screen
eval dataset RouterScreen menu
eval dataset list / eval dataset get DatasetPicker using PaginatedTablePicker
eval dataset get/:datasetId ResourceDetailScreen
eval dataset get/:datasetId/json JsonDetail

Testing

  • Added dataset.screen.test.tsx covering navigation, menu filtering, metadata rendering, etc.
  • bun run test (892 pass, 0 fail)
image image

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 6, 2026
@codecov-commenter

codecov-commenter commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.39024% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.96%. Comparing base (2d79b36) to head (84034b5).
⚠️ Report is 1 commits behind head on refactor.

Files with missing lines Patch % Lines
src/components/DatasetPicker.tsx 98.38% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1932      +/-   ##
============================================
+ Coverage     96.94%   96.96%   +0.01%     
============================================
  Files           360      364       +4     
  Lines         20596    20758     +162     
============================================
+ Hits          19966    20127     +161     
- Misses          630      631       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 6, 2026
jariy17
jariy17 previously approved these changes Aug 6, 2026

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seperate the update commands in their own PR

import { coreOptsFromCtx } from "../../../utils";

export const createUpdateDatasetHandler = (core: Core, io: AppIO) =>
export const createUpdateDatasetHandler = (core: Core) =>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seperate the write only dataset handlers into their own pr.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was incorrectly pulling in commits from the dataset update CLI command PR. That's why this file was showing up. The PR is now showing the correct commits/diff now that I've fixed conflicts and rebased

Base automatically changed from datasets-update-cli to refactor August 13, 2026 16:34
@nborges-aws
nborges-aws force-pushed the datasets-readonly-TUI branch from e9e6be7 to 9e682f1 Compare August 13, 2026 17:25
<ResourceDetailScreen
breadcrumb={["agentcore", "eval", "dataset", "get", datasetId ?? ""]}
isPending={detail.isPending}
error={detail.isError ? (detail.error as Error) : null}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use AgentCoreCLIError.from here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah looking into it now, this is a good call out. It would probably make the most sense to use AgentCoreCLIError.from inside ResourceDetailScreen and the other shared resources. That way the its standardized across all screens. The call site would then just do:
detail.isError ? detail.error : null

@nborges-aws
nborges-aws force-pushed the datasets-readonly-TUI branch from 9e682f1 to 84034b5 Compare August 13, 2026 20:08
@nborges-aws
nborges-aws merged commit 4d183dc into refactor Aug 13, 2026
9 checks passed
@nborges-aws
nborges-aws deleted the datasets-readonly-TUI branch August 13, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants