Skip to content

feat(gateway): add read-only gateway commands - #1869

Merged
aidandaly24 merged 1 commit into
refactorfrom
feat/gateway-read-scaffolding
Jul 31, 2026
Merged

feat(gateway): add read-only gateway commands#1869
aidandaly24 merged 1 commit into
refactorfrom
feat/gateway-read-scaffolding

Conversation

@aidandaly24

Copy link
Copy Markdown
Contributor

Summary

  • add read-only gateway get/list, gateway target get/list, and gateway rule get/list commands
  • add the Gateway Core client boundary, concrete AWS SDK implementation, router wiring, help defaults, and controllable test client
  • add focused handler tests plus recorded AWS fixtures and golden output for successful, paginated, and not-found responses
  • document the new Gateway command tree and usage examples

Scope

This PR scaffolds Gateway read handlers only. It does not add Gateway mutations, synchronization, invocation, resource-policy or tag commands, or interactive TUI workflows.

Testing

  • bun test (524 passing, 0 failing across 47 files)
  • bun test --coverage (95.17% functions, 97.93% lines overall; Gateway implementation files at 100%)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • bun run compile (Darwin, Linux, and Windows on x64 and arm64)
  • source, bundled dist, native Linux binary, and packed-artifact help smokes for all six commands
  • script-free package creation and content audit
  • live e2e-test validation for all six reads and second-page token forwarding for Gateway, Target, and Rule lists

The recorded fixture graph uses persistent non-OAuth test resources and contains no credentials or secrets.

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 30, 2026
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (c7f857b) to head (e628edd).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1869      +/-   ##
============================================
+ Coverage     95.87%   95.98%   +0.11%     
============================================
  Files           198      208      +10     
  Lines          9379     9636     +257     
============================================
+ Hits           8992     9249     +257     
  Misses          387      387              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aidandaly24
aidandaly24 force-pushed the feat/gateway-read-scaffolding branch from dba8a06 to e628edd Compare July 30, 2026 22:26
@aidandaly24
aidandaly24 marked this pull request as ready for review July 30, 2026 22:36

@Hweinstock Hweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

expect(rule?.children().map((child) => child.name())).toEqual(["get", "list"]);
});

test.each(["gateway", "gateway target", "gateway rule"])(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really like the test.each pattern, makes for some clear, concise, tests.

@notgitika notgitika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@aidandaly24
aidandaly24 merged commit a08c73f into refactor Jul 31, 2026
8 checks passed
@aidandaly24
aidandaly24 deleted the feat/gateway-read-scaffolding branch July 31, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants