Repository navigation
Conversation
nborges-aws
left a comment
There was a problem hiding this comment.
A few callouts, but all minor changes. Overall LGTM
| cp agentcore/agentcore.json /tmp/agentcore.json.bak | ||
| cp agentcore/.env.local /tmp/env.local.bak 2>/dev/null | ||
| agentcore remove all --yes | ||
| agentcore deploy --yes |
There was a problem hiding this comment.
should this specify --target the example above uses staging as the target. If staging is not the default, this command would target the wrong stack
There was a problem hiding this comment.
Good catch — fixed in 48b40fd. Step 0 is now agentcore status --json --target <target> and step 2 is agentcore deploy --yes --target <target>, with a note that without --target deploy uses the default target, which may be a different stack.
|
|
||
| score=$(echo "$result" | jq -r '.run.results[0].aggregateScore // empty') | ||
| # Recent-traffic gate: | ||
| result=$(agentcore eval ondemand evaluate \ |
There was a problem hiding this comment.
shouldn't this pass a session-id? The text on L#313 says "score the sessions your integration tests just produced", but this would include results even outside of that session
There was a problem hiding this comment.
Agreed — fixed in 48b40fd. The recent-traffic gate now takes SESSION_IDS (the IDs the integration tests passed to agentcore invoke --session-id) and runs eval ondemand evaluate --session-ids instead of --lookback-days 1, so it only scores the sessions from that CI run.
| # --payload-template '{"prompt":"{input}"}' \ | ||
| # --evaluators "$EVALUATOR") || { echo "⚠️ Dataset replay failed" >&2; exit 1; } | ||
|
|
||
| score=$(echo "$result" | jq -r '[.results[] | select(.value != null) | .value] | if length == 0 then empty else add / length end') |
There was a problem hiding this comment.
I see we're dropping null in this calculation. Not sure exactly how this works, but would the value be null if the evaluation errored out? Because if so, we're gonna filter out all the errors and the result will be a false-positive success
There was a problem hiding this comment.
Yes, that was a false-pass risk. A result that fails to evaluate comes back with errorCode/errorMessage and no value, so filtering out nulls hid errors. Fixed in 48b40fd: the gate now counts results with an errorCode or a missing value, prints them, and exits 1 before computing the average. I checked the script against a stubbed result with one errored evaluation, and it fails as expected.
ef7f810 to
d148c09
Compare
38e65ef to
7a802fa
Compare
| [tasks."test:payment-scripts"] | ||
| description = "Run payment skill script tests" | ||
| run = """ | ||
| uv run --with pytest python -m pytest \ | ||
| plugins/aws-agents/skills/agents-build/scripts/test_setup_payment_user.py \ | ||
| plugins/aws-agents/skills/agents-pay/scripts/test_resource_resolution.py | ||
| """ |
There was a problem hiding this comment.
If you want custom ci workflows, please do something like startup-advisor so they are limited to changes in your plugin folder
Update agents-get-started, agents-deploy, agents-debug, agents-optimize, agents-harden, the CloudWatch Omni instrumentation reference, and the plugin README for AgentCore CLI v1.0.0 (templates, Harness vs Runtime, build/deploy/targets, logs/traces/status, eval subcommands, migrate).
Harness-endpoint-aware teardown and leftover cleanup, startup-crash debugging, inference-profile IAM scoping, preflight fixes for assumed-role creds and env regions, code-evaluator recipes, trace timing, metrics namespace, cost rates, dataset schema, and migrate git precondition.
Scope teardown to one target with explicit confirmation, fix startup-crash log query, consistent migrate approval flow, --json for non-TTY list commands, gateway auth table, CreateEvent quotas, CDK/ECR IAM naming, and trace timing consistency.
Judge model that accepts temperature, online-eval and trace timing, commit- before-plan migrate flow, complete BYO ECR/KMS and deploy IAM checks, target-safe teardown with .env.local backup and service-side eval cleanup, Harness coverage in harden, CodeZip version-creation caveat, Omni collector install, and accuracy nits.
- Teardown names the target on status/deploy so it can't hit the default stack. - Quality gate scores only the CI run's own sessions (--session-ids) and fails on errored evaluations (errorCode / no value) instead of dropping them. - Add teardown trigger phrases to agents-deploy; 'tear down' prompts were routing to agents-build's v0 teardown reference.
* feat(aws-agents): update skills to reflect AgentCore CLI v1 * fix(aws-agents): fix runtime and harness configuration guidance * fix(aws-agents): correct header allowlist example * fix(aws-agents): ensure agent deployment workflows persist selected target * fix(aws-agents): fix Privy guidance in payments skill * fix(aws-agents): persist selected target on gateway and policy operations * fix(aws-agents): fix payment admin setup instructions * fix(aws-agents): update agent auth and cross-session memory examples * fix: address review findings for agentcore CLI v1 skill updates * fix(aws-agents): require shim manifests and prefer v1 payment status
* fix(agents-build): require human approval for payment sessions * fix(agents-pay): validate deployment target configuration * docs(payments): correct v1 setup and spending guidance * docs(agents-build): correct browser setup guidance * docs(observability): clarify local traces and streaming errors * docs(agents-get-started): explain failed create recovery * docs(agents-connect): require MCP for semantic search * docs(amazon-bedrock): clarify Harness CLI inputs and cleanup * docs(amazon-bedrock): correct Harness migration and rollback guidance
Co-authored-by: jariy17 <tjariy+jariy17@users.noreply.github.com>
Added warning about deploying the Strands agent with the Browser tool as a Container Runtime due to packaging limitations.
97fa394 to
7f39e0a
Compare
Description
Updates the
aws-agentsskills owned by this half of the AgentCore CLI v1 split. Everyagentcorecommand, flag, config key and behaviour claim now matches AgentCore CLI v1.0.0 (@aws/agentcore@latest).Skills and files covered
agents-get-started:create --name --template)devports and behaviouragents-deployandreferences/versioning.md:buildplus a realcdk diffpreviewexportagents-debugandreferences/doctor.md:status,logs,tracesandinvokeformsagentcore migrateagents-optimize(evals,observability,cost):evalcommand tree: on-demand, batch, online, datasets, recommendationsAWS/Bedrock-AgentCoremetricsagents-hardenandreferences/limits.md:NONEomni-agents-instrumentation.md), AgentCore path only:"version": 2, including Harness-only projects)agentcore dev --no-traceswith.env.localplugins/aws-agents/README.md:Version policy: all updated skills declare
requires-cli: ">=1.0.0". If a user has an older CLI, the skills tell them to upgrade. For v0 projects ("version": 1) they say to commit, then review theagentcore migrateplan, then apply it with--yes.Not in this PR (owned separately):
agents-build,agents-connect,agents-payandamazon-bedrock.agents-build/references/teardown.mdstill describes v0, soagents-deployno longer links to it.How this was validated
agentcoreinvocation in the changed files was checked against the v1 CLI's--helpand source.Type of Change
Checklist
python3 tools/validate.pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.