Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for SecurityHub findings from CWL #181

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rjjaegeraws
Copy link
Contributor

Issue #, if available:
#180

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rjjaegeraws
Copy link
Contributor Author

This PR has been sitting for a long time, any thoughts or comments?

Here, attached to this comment is a test file that contains Security Hub events from CloudWatch logs. This file can be used to replicate the existing bug and validate this PR's fix
SH-Test.gz
.

@ghost
Copy link

ghost commented Oct 28, 2022

@rjjaegeraws i just tested this in my forked version and the SIEM is able to load securityhub logs with a minor tweak. I'm using the Export Security Hub Findings to S3 Bucket solution so i needed to modify your code to also check for detailType. The rest of your changes worked perfectly 👍🏾

if any([i in logdict for i in ["detail-type", "detailType"]]) and "resources" in logdict:
if any([i in dict_obj for i in ["detail-type", "detailType"]]) and "resources" in dict_obj:

@nakajiak i also ran into the same issue, which led me to the issue & resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant