Fix Bash script - #16
Open
housni wants to merge 1 commit into
Open
Conversation
…. Add pipefail option so that errors in a piped command cause the script to fail fast without masking it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
#!/usr/bin/env bashwhich is the more portable way to use a shebang since it queries the env for Bash instead of assuming it's installed at/bin/bashwhich is the most common location.pipefailoption to true so that if a piped command fails, it will not be hidden and will instead terminate the entire script which will help us avoid potential problems.