Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding programatic support for aws cli Profiles #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nbaillie
Copy link

@nbaillie nbaillie commented Nov 6, 2023

Description of changes in addition to ReadMe update:

  1. added 'use_profile' to bootstrap_account as an alternative to credentials, additionally account id for consumer and/or producer is determined now by using a the sts client for the appropriate connection.

  2. Class DataMeshAdmin is updated to handle the new option for 'use_profile' and will use this to connect the clients if supplied, 'use_profile' can not be used at the same time as 'use_credentials' and we raise error if we try and do that.

  3. the function assert_is_data_lake_admin is updated to handle the case were we use and STS assumed role and need to check that it is a data lake Admin.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@IanMeyers
Copy link
Contributor

Can you also please add support for these profiles in the data-mesh-cli so that these are available on the command line?

@nbaillie
Copy link
Author

nbaillie commented Nov 6, 2023

let me get on the CLI change as requested. Thanks @IanMeyers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants