Skip to content

Conversation

@priiiiit
Copy link
Contributor

Description of changes:

In my testing, I noticed that when the stack was deleted, the recordingMode was not reset to CONTINUOUS. This code resolves that issue.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vsr2158
Copy link
Contributor

vsr2158 commented Nov 15, 2025

Interesting. We never had this in the code and the rollback works.
Api docs does not mention whats the default https://docs.aws.amazon.com/cli/latest/reference/configservice/put-configuration-recorder.html

I agree hard coding defaults is a good idea to avoid future issues but I want to test the default behaviour once more before merging.

@vsr2158
Copy link
Contributor

vsr2158 commented Nov 15, 2025

Tested this and can conform it works without this fix/enhancement as is. However will look into adding this

[INFO] 2025-11-15T22:26:29.012Z cd99617f-2bfa-501c-a6a5-00ec2bb40d0c Post Change Configuration recorder : {'ConfigurationRecorders': [{'arn': 'arn:aws:config:us-west-2:<>:configuration-recorder/aws-controltower-BaselineConfigRecorder/fxlkl9lz98m7l2c1', 'name': 'aws-controltower-BaselineConfigRecorder', 'roleARN': 'arn:aws:iam::<>:role/aws-service-role/config.amazonaws.com/AWSServiceRoleForConfig', 'recordingGroup': {'allSupported': True, 'includeGlobalResourceTypes': True, 'resourceTypes': [], 'exclusionByResourceTypes': {'resourceTypes': []}, 'recordingStrategy': {'useOnly': 'ALL_SUPPORTED_RESOURCE_TYPES'}}, 'recordingMode': {'recordingFrequency': 'CONTINUOUS', 'recordingModeOverrides': []}, 'recordingScope': 'PAID'}], 'ResponseMetadata': {'RequestId': '0838b7b2-5185-4a57-9197-22efeb32a5d8', 'HTTPStatusCode': 200, 'HTTPHeaders': {'x-amzn-requestid': '0838b7b2-5185-4a57-9197-22efeb32a5d8', 'strict-transport-security': 'max-age=86400', 'content-type': 'application/x-amz-json-1.1', 'content-length': '617', 'date': 'Sat, 15 Nov 2025 22:26:29 GMT'}, 'RetryAttempts': 0}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants