fix(metrics): align flush_metrics behavior with raise_on_empty_metrics documentation #7468
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…65671f9e2077eac36fd480b3814d7a9b978/aws_lambda_powertools/metrics/provider/cloudwatch_emf/cloudwatch.py#L383 Addressing issue aws-powertools#7467 Signed-off-by: Jota Feldmann <[email protected]>
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
the
size/XS
jotafeldmann
changed the title
|
|
This PR review is paused until we clarify this: #7467 (comment) |
leandrodamascena
added
the
on-hold
leandrodamascena
requested review from
leandrodamascena
and removed request for
anafalcao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #7467
Issue number: closes #7467
Summary
Align
flush_metricsbehavior with theraise_on_empty_metricsdocumentation.When
raise_on_empty_metrics=False, no exception should be raised regardless of whether metrics exist.Changes
flush_metricsfromif not raise_on_empty_metrics and not self.metric_set:toif not raise_on_empty_metrics:User experience
Before:
Even when
raise_on_empty_metrics=False, the code still considered the presence of metrics and could raise exceptions inconsistently.After:
When
raise_on_empty_metrics=False, no exception is raised regardless of metric set state, which is consistent with the documented intent.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.