Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Timestamp to sensor_msgs/Image and Parameters #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

larsll
Copy link

@larsll larsll commented Jul 17, 2021

Issue Number (if available): N/A

Description of changes:

  • Populating the message header with a timestamp and unique identifier to allow for more accurate video production downstream.
  • Add a parameter to define the rescaling factor
  • Add a parameter to limit the number of frames per second to be produced
  • Add a parameter to turn off the display stream
    --

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@larsll larsll changed the title Adding Timestamp to sensor_msgs/Image Adding Timestamp to sensor_msgs/Image and Parameters Oct 5, 2021
@pratik-nichat
Copy link
Member

pratik-nichat commented Oct 21, 2021

Hello @larsll,
Thank you for your interest in the AWS DeepRacer open-source initiative. I went through your commits and have a few comments regarding couple of them.

  1. This commit should not be present since its already a part of the main branch currently, so if you could rebase your changes and remove this local commit, it would be cleaner.
  2. Regarding this commit: The resizing has been originally set as default to 160x120 size image since this is the size that is expected by the neural network for inference as part of the AWS DeepRacer Core application. Hence suggestion is to keep a parameter to support this for the AWS DeepRacer core application specifically. I will leave it upto you to decide how to design that along with resizing wrt other scales.
    Thanks,
    Pratik

@larsll
Copy link
Author

larsll commented May 14, 2022

@pratik-nichat - After some motivating racing on Summit Berlin I have gone back and updated this Pull request. It should be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants