fix: report resolve references errors for adopt-or-create
#206
Conversation
Currently we have been ignoring `ResolveReferences` errors for all adoptions and readOnly. Ignoring the error for `adopt-or-create` is an antipattern, since we want to ensure users are aware of these issues. In the case of `adopt`, since the spec will fully be rewritten, we would not need to resolve references at all.
michaelhtm
force-pushed
the
fix/reportreferenceserrorsforadoptorcreate
branch
from
46bb7a2 to
b59d658
Compare
|
thanks @michaelhtm ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Issue #2641
Description of changes:
Currently we have been ignoring
ResolveReferenceserrors for alladoptions and readOnly.
Ignoring the error for
adopt-or-createis an antipattern, since we wantto ensure users are aware of these issues.
In the case of
adopt, since the spec will fully be rewritten, we wouldnot need to resolve references at all.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.