Skip to content

feat: Make helm chart names dynamic #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

Issue #2430

Description of changes:
extra changes:
add labels to roles/rolebindings

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 May 14, 2025 20:37
Copy link

ack-prow bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label May 14, 2025
@michaelhtm michaelhtm force-pushed the feat/renameclusterroles branch from b20cdd3 to 810b97a Compare May 14, 2025 20:46
extra changes:
add labels to roles/rolebindings
@michaelhtm michaelhtm force-pushed the feat/renameclusterroles branch from 810b97a to 1a3ee22 Compare May 14, 2025 21:13
Copy link

ack-prow bot commented May 14, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 1a3ee22 link false /test verify-attribution
s3-olm-test 1a3ee22 link false /test s3-olm-test
ecr-controller-test 1a3ee22 link true /test ecr-controller-test
eventbridge-controller-test 1a3ee22 link true /test eventbridge-controller-test
iam-controller-test 1a3ee22 link true /test iam-controller-test
efs-controller-test 1a3ee22 link true /test efs-controller-test
acm-controller-test 1a3ee22 link true /test acm-controller-test
pipes-controller-test 1a3ee22 link true /test pipes-controller-test
apigatewayv2-controller-test 1a3ee22 link true /test apigatewayv2-controller-test
lambda-controller-test 1a3ee22 link true /test lambda-controller-test
s3-controller-test 1a3ee22 link true /test s3-controller-test
prometheusservice-controller-test 1a3ee22 link true /test prometheusservice-controller-test
dynamodb-controller-test 1a3ee22 link true /test dynamodb-controller-test
ec2-controller-test 1a3ee22 link true /test ec2-controller-test
documentdb-controller-test 1a3ee22 link true /test documentdb-controller-test
cloudfront-controller-test 1a3ee22 link true /test cloudfront-controller-test
eks-controller-test 1a3ee22 link true /test eks-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

name: ack-namespaces-cache-{{ .ControllerName }}-controller
name: {{ IncludeTemplate "app.fullname" }}-namespaces-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelhtm ! is app.fullname unique per installation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants