adding support for map[string]bool types
#579
Conversation
rushmash91
changed the title
map[string]bool typesmap[string]bool types
|
EC2 is flacky.. |
pkg/generate/code/set_sdk.go
Outdated
| return out | ||
| } | ||
|
|
||
| func getAWSMapType(valueType string) string { |
There was a problem hiding this comment.
I'm thinking if we can use a more descriptive name here resolveAWSMapValueType or nativeTypeToAWSType, maybe a comment to the function can help as well
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm cancel |
|
/lgtm |
|
/lgtm cancel |
|
will this just merge if we lgtm? @rushmash91 @michaelhtm - i'm asking because the commits are diverging |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/restest |
|
/retest |
|
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes: **Needs rebase to the removed shamelist** adding support `map[string]bool` types By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes: **Needs rebase to the removed shamelist** adding support `map[string]bool` types By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes: **Needs rebase to the removed shamelist** adding support `map[string]bool` types By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
Needs rebase to the removed shamelist
adding support
map[string]booltypesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.