Include aws beam core as a dep #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change moves the following files to a common lib: - aws_client - aws_util - aws_request - aws_rds_iam_token - aws_s3_presigned_url In particular the latter two may be very useful for libraries that do not need all of aws_erlang
There was a problem hiding this comment.
Copilot reviewed 4 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- src/aws.app.src: Language not supported
- src/aws_client.erl: Language not supported
- src/aws_rds_iam_token.erl: Language not supported
- src/aws_request.erl: Language not supported
- src/aws_s3_presigned_url.erl: Language not supported
- src/aws_util.erl: Language not supported
Comments suppressed due to low confidence (2)
README.md:14
- [nitpick] The word 'hence' is used incorrectly. It should be 'therefore' or 'thus.'
Any changes that need to be made should hence be made through [aws_beam_core](https://github.com/aws-beam/aws_beam_core) or [aws-codegen](https://github.com/aws-beam/aws-codegen) :exclamation:
README.md:128
- [nitpick] The word 'Hence' is used incorrectly. It should be 'Therefore' or 'Thus.'
Unfortunately the docs generated are too big for hexdocs.pm. Hence, the docs can be generated locally using:
jesperes
approved these changes
Jan 31, 2025
andreashasse
approved these changes
Feb 3, 2025
| @@ -1,7 +1,7 @@ | |||
| {erl_opts, [nowarn_unused_type, debug_info, {d, maps_support}]}. | |||
| {deps, [{hackney, "1.18.0"}, | |||
| {jsx, "3.0.0"}, | |||
| {aws_signature, "0.3.3"} | |||
| {aws_beam_core, "1.0.0"} | |||
There was a problem hiding this comment.
Not important for this PR: Since you are using hex.pm, you can use semver-like syntax
There was a problem hiding this comment.
I'm a 🐔 when it comes to the semver-like syntax. Even though aws_beam_core is owned by us, I'd prefer hard-pinning it just to ensure that updated dependencies are explicitly bumped rather than implicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include aws_beam_core as dependency of aws-erlang
AWS Beam Core is a sub-project of the larger AWS Beam projects. The aim of this project is to consolidate common functions into one place, eliminating the need to implement the same functionality in multiple places. It also resulted in
aws-erlangbeing a place to ONLY hold generated code without any hand-written code left behind inaws-erlang.Initially, AWS Beam Core will be integrated into AWS-Erlang, with plans to integrate into AWS-Elixir in the future.
This change moves the following files to the common lib:
- aws_client
- aws_util
- aws_request
- aws_rds_iam_token
- aws_s3_presigned_url
In particular the latter two may be very useful for libraries that do not need all of aws_erlang. Since they're simply moved, backwards compatibility is maintained with only the added dependency as a requirement.