Repository navigation
Conversation
- Use Connect, not Kinesis, as the credentials-provider example in the class doc comment and the README, and warn that Kinesis and Firehose share one offline cache per region. - README differences table: the plugin sends an API Hub event (no lifecycle event) for autoSignIn() and clearFederationToIdentityPool(), and the second sign-in rule covers an expiry saved by an earlier launch. - Decision 15 and design §14.8: a sign-out given no window shows no hosted-UI sign-out page and is .partial with hostedUIError. - Design change log: record the earlier restatement of limit 6.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4408 +/- ##
===========================================
+ Coverage 76.04% 88.17% +12.13%
===========================================
Files 1362 487 -875
Lines 57864 25405 -32459
===========================================
- Hits 44003 22401 -21602
+ Misses 13861 3004 -10857
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes inconsistencies in the AmplifyCognitoClient docs. No code changes, apart from a doc comment.
passed
work.credentialsProviderto anAmplifyKinesisClient. Kinesis and Firehose share one offline cache perregion, so two sessions that each wire one up can send each other's records (README, "Known limitations"). Both
examples now use
AmplifyConnectClient, as the design does for this example, and the README says why Kinesis andFirehose need care.
autoSignIn()andclearFederationToIdentityPool(): the plugin sends an API Hub event for each, justno lifecycle event. The table said "No Hub event".
said "in this process".
.failed. Neithersaid that a sign-out given no window (
signOut(options:),signOutStoredSession) shows no page and is.partialwith
hostedUIError, as §4.7 and the README already say.to say, and that restoring it is an open question.
General Checklist