fix: use options instead of this.options in PageViewTracker constructor #14549
+74
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamouda78
approved these changes
Sep 10, 2025
Simone319
approved these changes
Sep 10, 2025
sarayev
approved these changes
Sep 11, 2025
adrianjoshua-strutt
force-pushed
the
fix/josh/configureAutoTrackUrlProvider
branch
from
d0953fb to
d3e47e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed a bug in PageViewTracker constructor where
this.optionswas referenced before being initialized, causingeventNameandurlProviderto always use default values instead of user-provided options.Issue
fixes #14548
Description of how you validated changes
urlProviderconfigurationeventNameandurlProvideroptions are now properly appliedChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.