fix(tsc-compliance): Turn skiplibcheck flag on for tsc complaince skiplibcheck test #14257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig.ts4_2.json", | |||
| "compilerOptions": { | |||
| "skipLibCheck": false | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
Does setting skipLibCheckto true impact type checking of our types?
There was a problem hiding this comment.
I don't think it will. Currently in our tsc-compliance test, we have 2 tests named tsc-compliance:ts4.2 and tsc-compliance:skipLibCheck and the both are always running. Even after turning this flag on in skipLibCheck test, ts4.2 will still be type-checking all the declaration files.
AllanZhengYP
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
skipLibCheckflag in tsc-compliance test onIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.