feat: get tags and clean attributes #325
Open
+188
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Landed on this PR while trying to figure out why our new task definitions are not showing up existing tags. Would be great if this gets merged! |
|
@guikcd Do you have any ball park timeline for merging it? |
|
Not yet I didn't re-work on it since weeks. I was stuck on unit test; when I remove the added code, the tests with tags still pass. Seems that the test already pass unnecessary fields that are cleaned (in the test). |
|
This is golden! Running a fork with similar changes today, would really love to get rid of that 😄 |
|
Is there anything we can do to help get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes: #317
Description of changes:
Note: Most of clean code/logic/functions come from https://github.com/aws-actions/amazon-ecs-deploy-task-definition project.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.