Repository navigation
Fix the depower chain scripts on develop - #25
Merged
ocayon merged 2 commits intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes so that run_chain_depower_BILLOW.py → plot_billow_depower_chains.py runs end to end:
Tether: the chain script built a RigidLumpedTether by hand, while as_config.yaml sets tether.model: williams; the Williams trim refuses any other tether, so every chain failed. It now uses build_tether(config, system_config), as the Billow driver does.
Plot: chains.csv now has a boolean converged column, which read_chains tried to parse as a float. It is now read as a bool.
Tested: run_chain_depower_BILLOW.py --wind 5 --reach 0.1 --step 0.05 (6 converged points), then the plot script.
Not fixed here: run_sweep_depower_BILLOW.py (line 132) and plot_chordwise_moment_matching.py (line 118) also build a RigidLumpedTether by hand. The sweep script likely hits the same error; I'll check both in a follow-up.