Conversation
now can transform paths, subpaths and directions
Author
|
Sorry for the calculating mistakes. |
Author
|
I've created another gem |
Owner
|
@mrmeszaros pretty much, yeah - haven't updated the lib in ages, don't have any plans to do in the future. |
|
@awebneck I have no experience in doing releases to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @awebneck ,
I've made paths, sub paths and directions able to be transformed now.
For example
More examples can be found in
spec/transformable_spec.rb.Some directions are considered "not fully transformable". e.g.
HorizontalTodirections are not directly rotatable. An error will be raised if they are being rotated or skewed.So two methods ,
to_transformable_commands!andfully_transformable?are added to paths and sub_paths, to help them get transformed.However, this is transparent to users. Users only need to call
transform,scaleor other methods. Savage turns paths fully transformable before applying transforms.Could you take a review at this?