This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Improve create_dataset, video_to_slomo#60
Open
tobbez wants to merge 2 commits intoavinashpaliwal:masterfrom
Open
Improve create_dataset, video_to_slomo#60tobbez wants to merge 2 commits intoavinashpaliwal:masterfrom
tobbez wants to merge 2 commits intoavinashpaliwal:masterfrom
Conversation
This removes issues caused by file names containing special characters.
The previous length of 4 digits would cause frames out of order if you used a video with more than 9999 frames, e.g. a 240 fps longer than ~42 seconds. The new length of 9 should be high enough, with good margin (allowing for 48+ days of 240 fps video).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subprocess.check_callinstead ofos.system. This means even file names with special characters (e.g.") will work correctly.