Repository navigation
avoid pack index scans in restack tree rendering - #774
Conversation
Current Aviator status
This PR was merged using Aviator (commit 6473453).
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughBranch hash suffix rendering now reads local branch references directly, falls back to remote-tracking references, and uses the first seven hash characters when a reference is found. ChangesBranch hash suffix lookup
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request optimizes the View rendering performance in internal/sequencer/sequencerui/ui.go by replacing the slow ResolveRevision call with a direct branch reference lookup (Reference), falling back to the remote tracking branch if the local branch does not exist. This avoids expensive hash-prefix expansion scans on every render frame. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
✅ FlexReview StatusCommon Owner:
Review SLO: |
the restack view resolved every branch per render frame via ResolveRevision, whose hash-prefix expansion linearly scans the whole pack index in go-git v6 (syscall per entry). on a 2.9M-object repo this turned no-op syncs into ~20s+ of pure CPU. direct ref lookup instead, verified ~112s -> 0.6s on a synthetic repo at that scale
Summary by CodeRabbit