Skip to content

chore(deps): upgrade to charmbracelet v2 - #753

Merged
aviator-app[bot] merged 2 commits into
masterfrom
charmbracelet-v2
Jun 1, 2026
Merged

aviator-app[bot] merged 2 commits into
masterfrom
charmbracelet-v2

Conversation

@tulioz

@tulioz tulioz commented May 30, 2026

Copy link
Copy Markdown
Contributor

promptkit 0.11.0 pulls in charmbracelet v2, so this migrates the codebase off v1. folds in the 4 dependabot bumps from #752.

Bumps the golang group with 4 updates in the / directory: [github.com/erikgeiser/promptkit](https://github.com/erikgeiser/promptkit), [github.com/rogpeppe/go-internal](https://github.com/rogpeppe/go-internal), [golang.org/x/mod](https://github.com/golang/mod) and [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty).


Updates `github.com/erikgeiser/promptkit` from 0.9.0 to 0.11.0
- [Release notes](https://github.com/erikgeiser/promptkit/releases)
- [Commits](erikgeiser/promptkit@v0.9.0...v0.11.0)

Updates `github.com/rogpeppe/go-internal` from 1.14.1 to 1.15.0
- [Release notes](https://github.com/rogpeppe/go-internal/releases)
- [Commits](rogpeppe/go-internal@v1.14.1...v1.15.0)

Updates `golang.org/x/mod` from 0.35.0 to 0.36.0
- [Commits](golang/mod@v0.35.0...v0.36.0)

Updates `github.com/mattn/go-isatty` from 0.0.20 to 0.0.22
- [Commits](mattn/go-isatty@v0.0.20...v0.0.22)

---
updated-dependencies:
- dependency-name: github.com/erikgeiser/promptkit
  dependency-version: 0.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang
- dependency-name: github.com/rogpeppe/go-internal
  dependency-version: 1.15.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang
- dependency-name: golang.org/x/mod
  dependency-version: 0.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang
- dependency-name: github.com/mattn/go-isatty
  dependency-version: 0.0.22
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: golang
...

Signed-off-by: dependabot[bot] <support@github.com>
@aviator-app

aviator-app Bot commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator (commit 41efeb6).


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the application's TUI components from the original Charmbracelet libraries to their v2 forks under the charm.land namespace, updating imports, event types, and model View signatures to return tea.View. It also adds support for non-interactive environments by bypassing the renderer when stdin or stdout are not terminals. The review feedback highlights several critical compilation errors caused by directly concatenating tea.View objects with strings in the spinner views. Additionally, the feedback recommends checking if the terminal is interactive before querying the background color to prevent output corruption from OSC 11 sequences, and suggests adding defensive nil-checks and safe type assertions in the Bubble Tea runner.

Comment thread internal/actions/find_adoptable_local_branches.go
Comment thread internal/gh/ghui/push.go
Comment thread internal/git/gitui/prune.go
Comment thread internal/utils/colors/bgcolor.go
Comment thread internal/utils/colors/bgcolor.go Outdated
Comment thread internal/utils/uiutils/tea.go
@tulioz
tulioz force-pushed the charmbracelet-v2 branch 3 times, most recently from 691dfd9 to 8b14f13 Compare June 1, 2026 17:51
@tulioz
tulioz marked this pull request as ready for review June 1, 2026 17:58
@tulioz
tulioz requested a review from a team as a code owner June 1, 2026 17:58
@aviator-app

aviator-app Bot commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • ✅ aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 go.mod
    • 🔒 go.sum
    • 🔒 cmd/av/adopt.go
    • 🔒 cmd/av/commit_common.go
    • 🔒 cmd/av/next.go
    • 🔒 cmd/av/reparent.go
    • 🔒 cmd/av/restack.go
    • 🔒 cmd/av/switch.go
    • 🔒 cmd/av/sync.go
    • 🔒 cmd/av/tidy.go
    • 🔒 cmd/av/tree.go
    • 🔒 cmd/av/validate_db.go
    • 🔒 internal/actions/adopt_branches.go
    • 🔒 internal/actions/adopt_tree_selector.go
    • 🔒 internal/actions/find_adoptable_local_branches.go
    • 🔒 internal/actions/get_remote_stacked_pr.go
    • 🔒 internal/actions/git_fetch.go
    • 🔒 internal/gh/ghui/fetch.go
    • 🔒 internal/gh/ghui/push.go
    • 🔒 internal/git/gitui/ff_trunk.go
    • 🔒 internal/git/gitui/prune.go
    • 🔒 internal/sequencer/sequencerui/ui.go
    • 🔒 internal/utils/colors/bgcolor.go
    • 🔒 internal/utils/colors/colorutils.go
    • 🔒 internal/utils/colors/tailwind.go
    • 🔒 internal/utils/stackutils/render_tree.go
    • 🔒 internal/utils/uiutils/add_newline.go
    • 🔒 internal/utils/uiutils/base_stacked_view.go
    • 🔒 internal/utils/uiutils/err_cmd.go
    • 🔒 internal/utils/uiutils/prompt.go
    • 🔒 internal/utils/uiutils/render_error.go
    • 🔒 internal/utils/uiutils/simple_command.go
    • 🔒 internal/utils/uiutils/simple_message.go
    • 🔒 internal/utils/uiutils/tea.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.
❕ This PR modifies 411 lines, which is larger than the Review SLO threshold.

@aviator-app
aviator-app Bot requested a review from jainankit June 1, 2026 17:59
Comment thread cmd/av/next.go
@tulioz
tulioz force-pushed the charmbracelet-v2 branch from 8b14f13 to 2187d7e Compare June 1, 2026 21:20
@tulioz
tulioz force-pushed the charmbracelet-v2 branch from 2187d7e to 85763af Compare June 1, 2026 21:24
@aviator-app
aviator-app Bot merged commit 41efeb6 into master Jun 1, 2026
4 of 5 checks passed
@aviator-app
aviator-app Bot deleted the charmbracelet-v2 branch June 1, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants