Repository navigation
chore(deps): upgrade to charmbracelet v2 - #753
Conversation
Bumps the golang group with 4 updates in the / directory: [github.com/erikgeiser/promptkit](https://github.com/erikgeiser/promptkit), [github.com/rogpeppe/go-internal](https://github.com/rogpeppe/go-internal), [golang.org/x/mod](https://github.com/golang/mod) and [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty). Updates `github.com/erikgeiser/promptkit` from 0.9.0 to 0.11.0 - [Release notes](https://github.com/erikgeiser/promptkit/releases) - [Commits](erikgeiser/promptkit@v0.9.0...v0.11.0) Updates `github.com/rogpeppe/go-internal` from 1.14.1 to 1.15.0 - [Release notes](https://github.com/rogpeppe/go-internal/releases) - [Commits](rogpeppe/go-internal@v1.14.1...v1.15.0) Updates `golang.org/x/mod` from 0.35.0 to 0.36.0 - [Commits](golang/mod@v0.35.0...v0.36.0) Updates `github.com/mattn/go-isatty` from 0.0.20 to 0.0.22 - [Commits](mattn/go-isatty@v0.0.20...v0.0.22) --- updated-dependencies: - dependency-name: github.com/erikgeiser/promptkit dependency-version: 0.11.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: github.com/rogpeppe/go-internal dependency-version: 1.15.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: golang.org/x/mod dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: github.com/mattn/go-isatty dependency-version: 0.0.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com>
Current Aviator status
This PR was merged using Aviator (commit 41efeb6).
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request migrates the application's TUI components from the original Charmbracelet libraries to their v2 forks under the charm.land namespace, updating imports, event types, and model View signatures to return tea.View. It also adds support for non-interactive environments by bypassing the renderer when stdin or stdout are not terminals. The review feedback highlights several critical compilation errors caused by directly concatenating tea.View objects with strings in the spinner views. Additionally, the feedback recommends checking if the terminal is interactive before querying the background color to prevent output corruption from OSC 11 sequences, and suggests adding defensive nil-checks and safe type assertions in the Bubble Tea runner.
691dfd9 to
8b14f13
Compare
✅ FlexReview StatusCommon Owner:
Review SLO: |
promptkit 0.11.0 pulls in charmbracelet v2, so this migrates the codebase off v1. folds in the 4 dependabot bumps from #752.