add proper UTF-8/16/32 encoding support #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
changed the title
aviatesk
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 68.21% 68.59% +0.38%
==========================================
Files 35 36 +1
Lines 3001 3066 +65
==========================================
+ Hits 2047 2103 +56
- Misses 954 963 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit introduces a major refactoring of position encoding handling throughout the JETLS codebase to properly support LSP's position encoding negotiation (`UTF-8`, `UTF-16`, and `UTF-32`). Key architectural changes: - Add `encoding::PositionEncodingKind.Ty` field to `ServerState` to track the resolved position encoding negotiated with the client - Also add `encoding` field to `FileInfo` struct to avoid having to pass `server::Server` object to several subroutines - Create new utils/string.jl module with comprehensive encoding conversion functions Also includes a bunch of test refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a major refactoring of position encoding handling throughout the JETLS codebase to properly support LSP's position encoding negotiation (UTF-8, UTF-16, and UTF-32).
Key architectural changes:
encoding::PositionEncodingKind.Tyfield toServerStateto track the resolved position encoding negotiated with the clientencodingfield toFileInfostruct to avoid having to passserver::Serverobject to several subroutinesAlso includes a bunch of test refactoring.