Skip to content

Hw1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hw1 #1

wants to merge 3 commits into from

Conversation

avalsa
Copy link
Owner

@avalsa avalsa commented Feb 26, 2017

No description provided.

@treplen
Copy link
Collaborator

treplen commented Feb 26, 2017

Протестировал при помощи gtest.
На двух тестах вылетает по сигналу SIGABRT, при том дампы не появляются.
Первый заваленный тест - тест копирующего конструктора. В данной реализации используется копирующий конструктор по умолчанию, однако при работе с динамеческой памятью он не подходит.
Второй - тест на обращение по ссылке к деконструированному объекту. В нем программа не может вызвать ни одной функции у удаленного элемента, что возможно связано с использованием абстрактного класса.
Ниже представлен код программы тестирования:

#include <gtest/gtest.h>
#include "StackImpl.h"

TEST(Constructor_Destructor__Test,Regular_Creation)
{
    Stack* stack= nullptr;
    for(int i=1;i<100;i++) {
        ASSERT_NO_THROW(stack = new StackImpl());
        ASSERT_EQ(stack->size(),0);
        ASSERT_NO_THROW(delete stack);
    }
}


//SIGABRT!!!
TEST(Constructor_Destructor__Test,Copy_Constructor)
{
    StackImpl* stack1= nullptr;
    StackImpl* stack2= nullptr;
    srand(time(0));
    ASSERT_NO_THROW(stack1 = new StackImpl());
    for(int i = 0;i<100;i++)
        ASSERT_NO_THROW(stack1->push(rand()));
    ASSERT_NO_THROW(stack2=new StackImpl(*stack1));
    for(int i = 0;i<100;i++) {
        int val1,val2;
        ASSERT_NO_FATAL_FAILURE(val1=stack1->pop());
        ASSERT_NO_FATAL_FAILURE(val2=stack2->pop());
        ASSERT_EQ(val1,val2);
    }
    ASSERT_NO_THROW(delete stack1);
    ASSERT_NO_THROW(delete stack2);
}

//SIGABRT!!!
TEST(Constructor_Destructor__Test,Pointer_To_Destructed_Object)
{
    Stack* stack;
    {
        StackImpl stack1;
        stack=&stack1;
    }
    ASSERT_EQ(POISON,stack->size());
}

TEST(Status__Test,Get_Size)
{
    srand(time(0));
    for(int i=0;i<100;i++)
    {
        int size=rand()%1000+1;
        Stack* stack = nullptr;
        ASSERT_NO_THROW(stack=new StackImpl());
        for(int j = 0;j<size;j++)
            stack->push(0);
        ASSERT_EQ(size,stack->size());
        delete stack;
    }
}

TEST(Status__Test,Empty)
{
    srand(time(0));
    for(int i=0;i<100;i++)
    {
        int capacity=rand()%1000+1;
        Stack* stack = nullptr;
        ASSERT_NO_THROW(stack=new StackImpl());
        ASSERT_TRUE(stack->empty());
        for(int j = 0;j<capacity;j++)
        {
            stack->push(0);
            ASSERT_FALSE(stack->empty());
        }
        for(int j = 0;j<capacity;j++)
        {
            ASSERT_FALSE(stack->empty());
            stack->pop();
        }
        ASSERT_TRUE(stack->empty());
        delete stack;
    }
}

TEST(Methods___Test,Push_Top)
{
    srand(time(0));
    StackImpl stack;
    for(int i =0;i<100;i++)
    {
        int value = rand();
        ASSERT_NO_THROW(stack.push(value));
        ASSERT_EQ(value,stack.top());
    }
}

TEST(Methods___Test,Push_Pop)
{
    srand(time(0));
    StackImpl stack;
    int array[100];
    for(int i =0;i<100;i++)
    {
        int value = rand();
        array[i]=value;
        ASSERT_NO_THROW(stack.push(value));
    }
    for(int i = 99;i>=0;i--)
    {
        int value=0;
        ASSERT_NO_THROW(value=stack.pop());
        ASSERT_EQ(value,array[i]);
    }
}

TEST(Methods___Test, Pop_Top_From_Empty)
{
    Stack* stack;
    srand(time(0));
    stack=new StackImpl();
    ASSERT_THROW(stack->top(),const char*);
    ASSERT_THROW(stack->pop(),const char*);
    ASSERT_NO_THROW(stack->push(0));
    ASSERT_NO_THROW(stack->pop());
    ASSERT_THROW(stack->top(),const char*);
    ASSERT_THROW(stack->pop(),const char*);
}

int main(int argc, char *argv[])
{
    ::testing::InitGoogleTest(&argc, argv);
    return RUN_ALL_TESTS();
}

Problem: don't know how to solve 2-nd problem without rewriting code
totally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants