Skip to content

Improve AWS deploy waiters #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mariano merged 1 commit into from
Nov 8, 2025
Merged

Improve AWS deploy waiters #885

mariano merged 1 commit into from
Nov 8, 2025
+61 −11

Conversation

@mariano
Copy link
Collaborator

@mariano mariano commented Nov 7, 2025

Summary

  • wrap boto3 waiters returned by the async AWS client so their wait calls execute in the thread executor
  • update the AWS deployment tests to cover the new AsyncWaiter helper and ensure waiter invocations are awaited

Testing

  • poetry run pytest --verbose -s

Codex Task

@mariano mariano merged commit 9106aa5 into main Nov 8, 2025
8 checks passed
@mariano mariano deleted the improve-deploy-module branch November 8, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mariano