Skip to content

Replace arrgv with args-tokenizer #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Dec 29, 2024

Recently published args-tokenizer package. We use it at Webstudio for parsing cURL on paste. Also used at https://github.com/antfu-collective/bumpp.

There are a few benefits

  • published with type definitions
  • parser is forgiving to unclosed quotes which can be more user friendly
  • actively supported, arrgv last release was 5 years ago

The package also is esm only but used only in CLI so should not be a problem with commonjs. Though I can add cjs support if necessary.

https://github.com/TrySound/args-tokenizer

Recently published args-tokenizer package. We use it at Webstudio for
parsing cURL on paste. Used at
https://github.com/antfu-collective/bumpp.

There are two benefits
- published with type definitions
- parser is forgiving to unclosed quotes which can be more user friendly

The package also is esm only but used only in CLI so should not be a
problem with commonjs. Though I can add cjs support if necessary.

https://github.com/TrySound/args-tokenizer
@sindresorhus
Copy link
Member

I don't think silently forgiving invalid input is an improvement.

@TrySound
Copy link
Contributor Author

Will "strict" option work for you? I can add it

@TrySound
Copy link
Contributor Author

Upgraded to new strict by default version and reverted test changes

@novemberborn
Copy link
Member

novemberborn commented Jun 6, 2025

@TrySound apologies for ignoring this for so long. What would give more confidence is if you incorporate arrgvs test cases, that way it's easier to treat this as a like-for-like substitution. Shipping a 1.0 would also be great.

@novemberborn novemberborn marked this pull request as draft June 6, 2025 20:54
@novemberborn
Copy link
Member

@TrySound apologies for ignoring this for so long. What would give more confidence is if you incorporate arrgvs test cases, that way it's easier to treat this as a like-for-like substitution. Shipping a 1.0 would also be great.

To follow up on this, you're asking to replace a dependency that as far as I know hasn't caused problems with a modern version you wrote. That's great! But the less work for me to verify the behavior is exactly the same, the better.

@TrySound
Copy link
Contributor Author

TrySound commented Jun 7, 2025

Of course! Thanks for your response. Will update PR when release 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants