feat: convert tx reward manager npm test to go test #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
javascript
| return addr, contract | ||
| } | ||
|
|
||
| func TestRewardManager(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
tests look good? got the blackhole stuff in here
| // SendSimpleTx sends a simple ETH transfer transaction | ||
| // See ethclient/simulated/backend_test.go newTx() for the source of this code | ||
| // TODO(jonathanoppenheimer): after libevmifiying the geth code, investigate whether we can use the same code for both | ||
| func SendSimpleTx(t *testing.T, b *sim.Backend, key *ecdsa.PrivateKey) *types.Transaction { |
Member
Author
There was a problem hiding this comment.
not happy with adding this, would prefer to use an existing function...
JonathanOppenheimer
added
DO NOT MERGE
17 tasks
JonathanOppenheimer
changed the base branch from
master
to
JonathanOppenheimer/convert-tx-allow-list-test
…nathanOppenheimer/convert-reward-manager-test Signed-off-by: Jonathan Oppenheimer <[email protected]>
JonathanOppenheimer
removed
DO NOT MERGE
Member
Author
|
This should automatically rebase to target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Replaces reward manager allowlist e2e hardhat tests with golang bindings and a simulated backend test.
Part of #1228
How this works
Generates relevant golang bindings from sol files for the testing. Mirrors the hardhat test to a golang test using simulated backend.
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No