Skip to content

sync: coreth PR #1271: style: enable depguard linter #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2025
Merged

sync: coreth PR #1271: style: enable depguard linter #1886

merged 4 commits into from
Dec 4, 2025

Conversation

@JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Dec 2, 2025

Syncs ava-labs/coreth#1271

  • Requesting @alarso16 for review as he was the first approver
  • Requesting @StephenButtolph for review as he was the merging approver.

JonathanOppenheimer and others added 2 commits December 2, 2025 12:32
@JonathanOppenheimer @alarso16 @StephenButtolph
style: enable depguard linter (#1271)
1f8de4d 
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
@JonathanOppenheimer
style: rest of require replacement
4144ea0
@JonathanOppenheimer JonathanOppenheimer self-assigned this Dec 2, 2025
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner December 2, 2025 17:37
JonathanOppenheimer
JonathanOppenheimer commented Dec 2, 2025
View reviewed changes
@JonathanOppenheimer JonathanOppenheimer mentioned this pull request Dec 2, 2025
Open
17 tasks
michaelkaplan13
michaelkaplan13 reviewed Dec 3, 2025
View reviewed changes
@JonathanOppenheimer JonathanOppenheimer mentioned this pull request Dec 3, 2025
Open
michaelkaplan13
michaelkaplan13 approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared against the corresponding coreth PR, this all LGTM.

Question though: Why/how is it that github.com/stretchr/testify/assert is still imported within the accounts/abi and eth packages?

@JonathanOppenheimer
Copy link
Member Author

JonathanOppenheimer commented Dec 3, 2025

Compared against the corresponding coreth PR, this all LGTM.

Question though: Why/how is it that github.com/stretchr/testify/assert is still imported within the accounts/abi and eth packages?

accounts/abi and eth are upstream, old geth packages, and we don't enforce the AvalancheGo linting configuration on upstream files (so assert is okay). Only the more limited .golangci.yml is enforced, which does not contain depguard.

@ceyonur ceyonur added this pull request to the merge queue Dec 4, 2025
Merged via the queue into master with commit 2aa48f2 Dec 4, 2025
13 checks passed
@ceyonur ceyonur deleted the JonathanOppenheimer/sync-pr-1271-lint-enable-depguard branch December 4, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyonur ceyonur ceyonur approved these changes

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@alarso16 alarso16 alarso16 approved these changes

@StephenButtolph StephenButtolph Awaiting requested review from StephenButtolph

Assignees

@JonathanOppenheimer JonathanOppenheimer

Labels

coreth sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanOppenheimer @ceyonur @michaelkaplan13 @alarso16