-
Notifications
You must be signed in to change notification settings - Fork 126
Ensure the avalanchego binary is always current with a version-checked install #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d9421d
to
84bee4d
Compare
Getting these warnings locally due to
|
Would you prefer the script doesn't produce that output, or that the rpc version ignore lines that aren't json? |
931de29
to
68073cc
Compare
Just noting it when I run. Ideally, a normal run does not produce a warn log imo |
Before this PR is merged, ava-labs/avalanchego#3869 needs to merge and then this PR updated with a commit has merged to master. |
Previously the morpheusvm run script relied on manually building avalanchego from source. To ensure the required version of avalanchego is always used, a new script wrapping `go run` of avalanchego at the required version is introduced and the run script updated to use it.
5af8f69
to
a009fe2
Compare
go run
627f4ea
to
e7302da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after merging #2022
Updated to install to a central location (~/.cache/versioned-binaries) so that worktrees (or other repos) can reuse an installed binary. |
a9c839c
to
9639750
Compare
Previously the morpheusvm run script relied on manually building avalanchego from source. To ensure the required version of avalanchego is always used, a new script wrapping a version-checked install of avalanchego at the required version is introduced and the run script is updated to use it.
TODO
go run
avalanchego#3869