Followup pre populate chain validity window #2012
Conversation
* Add NewPopulatedTimeValidityWindow for direct initialization * Simplify validity window population with consistent timestamp comparison * Improve VM initialization flow to handle validity window during restart * Unify calculateOldestAllowed function implementation * Update component initialization order to break circular dependencies
|
hypersdk/internal/validitywindow/syncer.go Line 138 in 5d39841 Line 83 in 5d39841 Line 727 in 5d39841 Line 718 in 5d39841 |
| // AddNormalOpStarter registers a callback that will be executed when the engine invokes SetState(snow.NormalOp) | ||
| // i.e., transitioning from state sync / bootstrapping to normal operation. |
There was a problem hiding this comment.
Note: these will also be called on SetState(snow.NormalOp) when still performing dynamic state sync.
We could try and make that explicitly handled here so that the snow package can support callbacks for actually entering normal operation (ie. exclude dynamic state sync).
…-populate-chain-validity-window
…p safety checks enhance VW implementation with a populated flag that tracks whether a complete validity window has been observed. Reducing API surface area
…uring consistent view of state across the network
| log: log, | ||
| tracer: tracer, | ||
| chainIndex: chainIndex, | ||
| seen: emap.NewEMap[T](), | ||
| getTimeValidityWindow: getTimeValidityWindowF, | ||
| populated: false, | ||
| } | ||
| if lastAcceptedBlock != nil { |
There was a problem hiding this comment.
Allowing nil lastAcceptedBlock for testing purposes. While not ideal for production use, passing nil signals the creation of an empty validity window. The constructor handles this case gracefully. I'm open to improvements.
vw := NewTimeValidityWindow(ctx, log, tracer, chainIndex, nil, ...)
…`startNormalOp` ensuring both paths leading to normal operation require populated validity window
This PR addresses several issues related to the validity window initialization flow.
Improved Validity Window API:
NewPopulatedTimeValidityWindowas a factory method to create and populate a validity window in one steppopulateValidityWindowprivate (formerlyPopulateValidityWindow) to reduce API surface areapopulateValidityWindowCleaner VM Initialization Flow:
Validity Window Initialization