Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processing_time_visualizer): enable to give topic by command arg #95

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 14, 2024

Description

Current processing_time_visualizer need interactive input which is not good to use in scripts.
This PR add

  • topic choice with node argument with prefix -t

Sample usage

ros2 run autoware_debug_tools processing_time_visualizer -t /perception/object_recognition/prediction/map_based_prediction/debug/processing_time_detail_ms

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi changed the title feat(processing_time_visualizer): add non interactive mode feat(processing_time_visualizer): enable to give topic by command arg Aug 14, 2024
@YoshiRi YoshiRi requested a review from yhisaki August 14, 2024 09:21
Copy link
Contributor

@yhisaki yhisaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yhisaki yhisaki enabled auto-merge (squash) August 15, 2024 02:59
@yhisaki yhisaki merged commit 03b7867 into main Aug 15, 2024
31 checks passed
@yhisaki yhisaki deleted the feat/processing_time_visualizer_add_topic_name branch August 15, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants