Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception_reproducer): support reproduce/replay old rosbags #40

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Jun 7, 2024

Description

Fix a bug that perception_replayer/perception_reproducer can't publish old 'autoware_auto_perception_msgs' in old rosbags, by converting old autoware_auto_perception_msgs messages to autoware_perception_msgs messages

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xtk8532704 xtk8532704 requested a review from takayuki5168 June 7, 2024 08:54
@xtk8532704 xtk8532704 changed the title fix(perception_reproducer): Support reproduce/replay old rosbags. fix(perception_reproducer): Support reproduce/replay old rosbags Jun 10, 2024
xtk8532704 and others added 3 commits June 10, 2024 11:35
…h old 'autoware_auto_perception_msgs' in old rosbags.

Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
@xtk8532704 xtk8532704 force-pushed the fix/support_old_rosbag branch from c5febc1 to 68ff984 Compare June 10, 2024 02:37
@xtk8532704 xtk8532704 changed the title fix(perception_reproducer): Support reproduce/replay old rosbags fix(perception_reproducer): support reproduce/replay old rosbags Jun 10, 2024
@xtk8532704 xtk8532704 enabled auto-merge (squash) June 10, 2024 04:29
@xtk8532704 xtk8532704 merged commit e407349 into main Jun 11, 2024
27 of 28 checks passed
@xtk8532704 xtk8532704 deleted the fix/support_old_rosbag branch June 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants