Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): update README.md and Dockerfile.svg #5696

Merged
merged 6 commits into from
Jan 27, 2025
Merged

chore(docker): update README.md and Dockerfile.svg #5696

merged 6 commits into from
Jan 27, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 27, 2025

Description

Based on the updates to the following two PRs, this PR also updates the README.md and Dockerfile.svg.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@youtalk
update svg
d623caa 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
update readme
33beebe 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
update sentence
f745cf2 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
fix base
0bdde53 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from oguzkaganozt as a code owner January 27, 2025 00:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Jan 27, 2025
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Jan 27, 2025
xmfcx
xmfcx approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow the graph is very complicated 🤯

pre-commit failed with the svg 🤔

@xmfcx
Copy link
Contributor

xmfcx commented Jan 27, 2025

I ran pre-commit run -a to manually fix the remaining svg lint error ✅ d9787cd

@youtalk youtalk enabled auto-merge (squash) January 27, 2025 01:14
@youtalk youtalk merged commit a7423b1 into main Jan 27, 2025
16 of 18 checks passed
@youtalk youtalk deleted the chore/update-dockerfile-svg branch January 27, 2025 03:41
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

@esteve esteve Awaiting requested review from esteve

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees

@youtalk youtalk

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtalk @xmfcx