Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_graph_utils): use StringStamped in autoware_internal_debug_msgs #9741

Conversation

takayuki5168
Copy link
Contributor

Description

Run the following command, and manually add autoware_internal_debug_msgs in the package.xml

find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::StringStamped/autoware_internal_debug_msgs::msg::StringStamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/string_stamped/autoware_internal_debug_msgs\/msg\/string_stamped/g' {} \;

Related links

autowarefoundation/autoware#5580

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 marked this pull request as ready for review December 23, 2024 14:33
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.80%. Comparing base (067ee7a) to head (e212fe8).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
system/diagnostic_graph_utils/src/node/logging.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9741      +/-   ##
==========================================
+ Coverage   29.76%   29.80%   +0.03%     
==========================================
  Files        1444     1447       +3     
  Lines      108625   108661      +36     
  Branches    42658    42658              
==========================================
+ Hits        32330    32384      +54     
+ Misses      73114    73092      -22     
- Partials     3181     3185       +4     
Flag Coverage Δ *Carryforward flag
differential 7.56% <0.00%> (?)
total 29.76% <ø> (+<0.01%) ⬆️ Carriedforward from 067ee7a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168
Copy link
Contributor Author

@isamu-takagi
Please review the PR when you have time.

@takayuki5168 takayuki5168 merged commit 50f7cb0 into autowarefoundation:main Dec 24, 2024
46 of 48 checks passed
@takayuki5168 takayuki5168 deleted the feat/use-string-stamped-in-autoware-internal-msgs-dignostic-graph-utils branch December 24, 2024 02:30
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 25, 2024
…debug_msgs (autowarefoundation#9741)

* feat(diagnostic_graph_utils): use StringStamped in autoware_internal_debug_msgs

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
…debug_msgs (autowarefoundation#9741)

* feat(diagnostic_graph_utils): use StringStamped in autoware_internal_debug_msgs

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 8, 2025
…debug_msgs (autowarefoundation#9741)

* feat(diagnostic_graph_utils): use StringStamped in autoware_internal_debug_msgs

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants