promote: agent timeout 600 default to homolog#705
Conversation
Set Omni agent timeout defaults and UI bounds to 600 seconds; verified locally and CI green.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the default agent timeout from 60 to 600 seconds across the codebase, updating UI forms, database schemas, API routers, and validation schemas. The review feedback suggests extracting the hardcoded timeout value into a shared constant to reduce duplication. Additionally, it recommends reverting unrelated changes in the generated SDK types file to prevent version drift.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "/voice/join": { | ||
| parameters: { | ||
| query?: never; | ||
| header?: never; | ||
| path?: never; | ||
| cookie?: never; | ||
| }; | ||
| get?: never; | ||
| put?: never; | ||
| /** | ||
| * Join a voice channel | ||
| * @description Join a voice channel via a voice-capable channel plugin. Returns the created session. | ||
| */ | ||
| post: operations["voiceJoin"]; | ||
| delete?: never; | ||
| options?: never; | ||
| head?: never; | ||
| patch?: never; | ||
| trace?: never; | ||
| }; |
There was a problem hiding this comment.
The generated SDK types file contains several new API paths (such as /voice/join, /voice/leave, /voice/sessions) and new channel types (such as a2a, twilio-whatsapp, internal) that are not part of the API changes in this PR. Since this PR is intended to promote only the agent timeout changes to homolog "without carrying unrelated dev/version drift", these generated types should be reverted or regenerated against the homolog API schema to avoid drift and potential integration issues.
| schemaConfig: MetadataSchema.optional(), | ||
| defaultStream: z.boolean().default(true), | ||
| defaultTimeout: z.number().int().positive().default(60), | ||
| defaultTimeout: z.number().int().positive().default(600), |
There was a problem hiding this comment.
The default agent timeout value of 600 is hardcoded in multiple schemas, database definitions, and runtime fallbacks across the codebase. To prevent code duplication and make future updates easier, consider defining a shared constant (e.g., DEFAULT_AGENT_TIMEOUT_SECONDS = 600) in a central location like packages/core and importing it where needed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e60e3b3a7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // ---- Agent Configuration (Instance Override) ---- | ||
| agentTimeout: integer('agent_timeout').notNull().default(60), | ||
| agentTimeout: integer('agent_timeout').notNull().default(600), |
There was a problem hiding this comment.
Changing the Drizzle schema default here does not update the actual Postgres defaults on existing deployments: the checked-in migrations still create instances.agent_timeout and agent_providers.default_timeout with DEFAULT 60, and this commit does not add an ALTER TABLE ... SET DEFAULT 600 migration. Any insert path that relies on the database default (for example service/direct Drizzle inserts with the timeout omitted, or operational SQL) will continue creating 60-second timeouts after migration, so the promoted default is only partially applied.
Useful? React with 👍 / 👎.
1 participant
Why
Promote the merged dev Agent Timeout 600s default/UI contract into homolog without carrying unrelated dev/version drift.
Includes
Live HML already applied
Verification