Skip to content

fix(api): keep session resolver helpers internal#701

Merged
namastex888 merged 1 commit into
devfrom
fix/dev-knip-agent-session-identity
Jun 3, 2026
Merged

fix(api): keep session resolver helpers internal#701
namastex888 merged 1 commit into
devfrom
fix/dev-knip-agent-session-identity

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Summary

  • Fix red dev CI from bunx knip by keeping internal agent-session-identity helper functions non-exported.
  • No behavior change: resolveKhalSessionId, explicit session extraction, and canonical KHAL session builder remain exported and tested.

Test Plan

  • bunx knip
  • bunx biome check packages/api/src/services/agent-session-identity.ts packages/api/src/services/__tests__/agent-session-identity.test.ts
  • (cd packages/api && bun test src/services/__tests__/agent-session-identity.test.ts src/plugins/__tests__/session-cleaner.test.ts) — 5 pass, 0 fail
  • (cd packages/api && bun run typecheck)

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ec89d270-8c71-4f95-a32c-db54f7b92b87

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dev-knip-agent-session-identity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restricts the visibility of the 'resolveKhalEnvironment' and 'channelToKhalSessionSegment' functions in 'packages/api/src/services/agent-session-identity.ts' by removing their 'export' keywords, making them internal to the module. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@namastex888 namastex888 merged commit a628fc0 into dev Jun 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants