fix(api): keep session resolver helpers internal#701
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request restricts the visibility of the 'resolveKhalEnvironment' and 'channelToKhalSessionSegment' functions in 'packages/api/src/services/agent-session-identity.ts' by removing their 'export' keywords, making them internal to the module. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
bunx knipby keeping internalagent-session-identityhelper functions non-exported.resolveKhalSessionId, explicit session extraction, and canonical KHAL session builder remain exported and tested.Test Plan
bunx knipbunx biome check packages/api/src/services/agent-session-identity.ts packages/api/src/services/__tests__/agent-session-identity.test.ts(cd packages/api && bun test src/services/__tests__/agent-session-identity.test.ts src/plugins/__tests__/session-cleaner.test.ts)— 5 pass, 0 fail(cd packages/api && bun run typecheck)