Do not strip non-ascii chars from outputFile #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Tango calls
unicode(fh.read(), errors='ignore')to readoutputFilecontents before sending them to thenotifyURL. This has the side effect of stripping any non-ascii characters, which leads to unreadable text in most non-English languages.Once Autolab is fixed (by merging autolab/Autolab#975) to support receiving unicode feedback messages, then there is no point in stripping non-ascii characters.
Then, we can just pass the file object, which is much simpler and is the way recommended by the python-requests documentation to send a file.