feat(UI-1541): improve project creation from template #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J1za
changed the title
RonenMars
reviewed
May 27, 2025
src/store/useProjectStore.ts
Outdated
| return state; | ||
| }); | ||
| try { | ||
| await ProjectsService.createFromManifest(projectManifest, currentOrganization?.id); |
There was a problem hiding this comment.
Please rename the function in ProjectsService to applyManifest.
src/store/useProjectStore.ts
Outdated
Comment on lines
178
to
179
| await ProjectsService.delete(projectData.projectId); | ||
| return { data: undefined, error }; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think we shouldn't add Logger, because already have inside ProjectsService
J1za
commented
May 28, 2025
src/store/useProjectStore.ts
Outdated
| } | ||
|
|
||
| projectName = project.name; | ||
| return { data: undefined, error: new Error("Project name is required in manifest") }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For check limit request to server, instead of creating project by applyManifest,using projectClient.create
Linear Ticket
https://linear.app/autokitteh/issue/UI-1541/webui-templates-vscode-extension
What type of PR is this? (check all applicable)