Skip to content

feat(UI-1528): implement full screen session viewer functionality #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

J1za
Copy link
Collaborator

@J1za J1za commented May 15, 2025

Description

Implement FullScreen

Linear Ticket

https://linear.app/autokitteh/issue/UI-1528/full-screen-like-in-assets-for-sessions-list-hide-left-pane

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@RonenMars
Copy link
Contributor

Looking really good!
One usecase I tested and doesn't worked as expected:

  1. Go to project
  2. Create Deployment
  3. Run session (for example with webhook)
  4. Go to deployments table - click on the deployment to open the sessions table
  5. Open new tab/window in your browser, open the same sessions table filtered by deployment
  6. In the second window (from 5) go FullScreen
  7. In the first window delete the session
  8. Refresh the second window

Expected result: table with title "No session found"
Actual result: page with title "No session selected" - and it might confuse

Also if in this state you go to another deployment from the deployments table - you won't see the table, but only the first session full screen.

@J1za
Copy link
Collaborator Author

J1za commented May 28, 2025

Looking really good! One usecase I tested and doesn't worked as expected:

  1. Go to project
  2. Create Deployment
  3. Run session (for example with webhook)
  4. Go to deployments table - click on the deployment to open the sessions table
  5. Open new tab/window in your browser, open the same sessions table filtered by deployment
  6. In the second window (from 5) go FullScreen
  7. In the first window delete the session
  8. Refresh the second window

Expected result: table with title "No session found" Actual result: page with title "No session selected" - and it might confuse

Also if in this state you go to another deployment from the deployments table - you won't see the table, but only the first session full screen.

I decided that we don't need to save in localStorage fullScreenSessionViewer, for better flexibility, pls check

@J1za J1za force-pushed the vitaly/feat/session-view-add-fullscreen branch from 92b9be0 to b3ebb53 Compare May 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants