Follow up changes for recent fixes: remove len downcasts and ensure all other downcasts are validated #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
remove-len-downcasts
branch
from
6fa4ac0 to
90dab43
Compare
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
remove-len-downcasts
branch
from
90dab43 to
4c92b09
Compare
vroldanbet
reviewed
Mar 6, 2024
internal/services/v1/errors.go
Outdated
| ) | ||
| } | ||
|
|
||
| // NewExceedsMaximumChecksErr creates a new error representing that too many updates were given to a WriteRelationships call. |
There was a problem hiding this comment.
Suggested change
| // NewExceedsMaximumChecksErr creates a new error representing that too many updates were given to a WriteRelationships call. | |
| // NewExceedsMaximumChecksErr creates a new error representing that too many updates were given to a CheckPermission call. |
| @@ -409,14 +410,25 @@ func (es *experimentalServer) BulkExportRelationships( | |||
| return nil | |||
| } | |||
|
|
|||
| const maxBulkCheckCount = 10000 | |||
There was a problem hiding this comment.
Was this meant to be 1K?
There was a problem hiding this comment.
No; since we didn't previously have a limit at all, I figured we'd set a super high limit for now and then lower it when BulkCheck is moved out of experimental
josephschorr
force-pushed
the
remove-len-downcasts
branch
from
4c92b09 to
a925bc8
Compare
josephschorr
force-pushed
the
remove-len-downcasts
branch
from
a925bc8 to
2f533cf
Compare
vroldanbet
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.