Skip to content

Fix video embed on observability page #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix video embed on observability page #234

merged 1 commit into from
Aug 22, 2024

Conversation

samkim
Copy link
Member

@samkim samkim commented Jun 21, 2024

Fixes #233

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 6:21am

@jzelinskie
Copy link
Member

What's broken here? I used the convention of adding the linebreak before the videos because html embedded in markdown doesn't maintain the implicit paragraphs that markdown inserts.

@samkim
Copy link
Member Author

samkim commented Jun 25, 2024

For some reason this particular Youtube tag wasn't being processed but wasn't able to figure out why only this one

@vroldanbet vroldanbet merged commit 67dca47 into main Aug 22, 2024
9 checks passed
@vroldanbet vroldanbet deleted the fix-observability branch August 22, 2024 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback for “Observability Tooling”
3 participants